Ax icon indicating copy to clipboard operation
Ax copied to clipboard

CrossValidationPlot analysis

Open mpolson64 opened this issue 1 year ago • 7 comments

Summary: New CrossValidationPlot using the Analysis framework. Plots CVResults of the current model on the provided GS with CI if available. Forces a square aspect ratio (but does not force any specific resolution). Hover data for x, y value with CI and arm name. Displays a gray dashed line on y=x.

This diff also refactors _select_metric out of Parallel Coordinates into a utils file so we can use it here to select the objective if no metric_name is provided.

NOTE: We are intentionally leaving the two dropdowns out: the "metric" dropdown because we want to generate many CVs separately and combine them more gracefully in the UI (cc Cesar-Cardoso), the latter because we dont actually want users to be able to view this without the confidence intervals (it is not useful).

Differential Revision: D64056891

mpolson64 avatar Oct 11 '24 16:10 mpolson64

This pull request was exported from Phabricator. Differential Revision: D64056891

facebook-github-bot avatar Oct 11 '24 16:10 facebook-github-bot

Codecov Report

Attention: Patch coverage is 96.29630% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b3dfe0e). Learn more about missing BASE report. Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ax/analysis/plotly/cross_validation.py 92.00% 4 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2861   +/-   ##
=======================================
  Coverage        ?   95.78%           
=======================================
  Files           ?      504           
  Lines           ?    49749           
  Branches        ?        0           
=======================================
  Hits            ?    47652           
  Misses          ?     2097           
  Partials        ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 11 '24 17:10 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D64056891

facebook-github-bot avatar Oct 11 '24 17:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64056891

facebook-github-bot avatar Oct 15 '24 15:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64056891

facebook-github-bot avatar Oct 15 '24 15:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64056891

facebook-github-bot avatar Oct 15 '24 15:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64056891

facebook-github-bot avatar Oct 15 '24 17:10 facebook-github-bot

This pull request has been merged in facebook/Ax@98dbb397e093d0e0df43dea7940405fb426e22a9.

facebook-github-bot avatar Oct 16 '24 21:10 facebook-github-bot