Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Add logs for when data-fetching actually starts

Open lena-kashtelyan opened this issue 1 year ago • 8 comments

Summary: Current logs are confusing, they make it look like we first fetch the data quite fast, then we retrieve completed trials, and then we do nothing for a while. This clarifies by rephrasing the "Fetching..." log to "will fetch" and logging the actual start of fetching with "..." at the end, indicating that it will take a bit.

Differential Revision: D64208425

lena-kashtelyan avatar Oct 11 '24 00:10 lena-kashtelyan

This pull request was exported from Phabricator. Differential Revision: D64208425

facebook-github-bot avatar Oct 11 '24 00:10 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.78%. Comparing base (dacedfc) to head (3b66e9e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2855      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         502      502              
  Lines       49687    49690       +3     
==========================================
+ Hits        47593    47595       +2     
- Misses       2094     2095       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 11 '24 00:10 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D64208425

facebook-github-bot avatar Oct 14 '24 21:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64208425

facebook-github-bot avatar Oct 14 '24 22:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64208425

facebook-github-bot avatar Oct 14 '24 22:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64208425

facebook-github-bot avatar Oct 15 '24 01:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64208425

facebook-github-bot avatar Oct 15 '24 01:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D64208425

facebook-github-bot avatar Oct 16 '24 19:10 facebook-github-bot