Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Derelativize for negative status quo constraint values

Open SebastianAment opened this issue 1 year ago • 4 comments

Summary:

This commit ensures that a relative constraint of < b, where b is a positive number, yields an absolute upper bound that is larger than the status quo even if the value of the status quo is negative.

Differential Revision: D63638706

SebastianAment avatar Oct 02 '24 20:10 SebastianAment

This pull request was exported from Phabricator. Differential Revision: D63638706

facebook-github-bot avatar Oct 02 '24 20:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63638706

facebook-github-bot avatar Oct 15 '24 16:10 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.78%. Comparing base (314aef4) to head (5e3ee08).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2813   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files         504      504           
  Lines       49770    49790   +20     
=======================================
+ Hits        47672    47692   +20     
  Misses       2098     2098           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 15 '24 17:10 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D63638706

facebook-github-bot avatar Oct 15 '24 18:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63638706

facebook-github-bot avatar Oct 16 '24 14:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63638706

facebook-github-bot avatar Oct 16 '24 16:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63638706

facebook-github-bot avatar Oct 16 '24 21:10 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D63638706

facebook-github-bot avatar Oct 16 '24 22:10 facebook-github-bot

This pull request has been merged in facebook/Ax@bd48713586c5de5e9b0eeb641eca3101d04e3876.

facebook-github-bot avatar Oct 17 '24 00:10 facebook-github-bot