Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Add `evaluate_oracle` method to `BenchmarkRunner`

Open esantorella opened this issue 1 year ago • 4 comments
trafficstars

Summary: Docstring should make this self-explanatory.

In addition to the increased ease of development, enables reaping a lot of LOC in D61415525

Reviewed By: Balandat

Differential Revision: D61431980

esantorella avatar Aug 23 '24 20:08 esantorella

This pull request was exported from Phabricator. Differential Revision: D61431980

facebook-github-bot avatar Aug 23 '24 20:08 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.28%. Comparing base (003983d) to head (e0841db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2705   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         493      493           
  Lines       47899    47903    +4     
=======================================
+ Hits        45639    45643    +4     
  Misses       2260     2260           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 23 '24 20:08 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D61431980

facebook-github-bot avatar Aug 24 '24 12:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61431980

facebook-github-bot avatar Aug 24 '24 12:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61431980

facebook-github-bot avatar Aug 24 '24 17:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61431980

facebook-github-bot avatar Aug 25 '24 20:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61431980

facebook-github-bot avatar Aug 25 '24 20:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61431980

facebook-github-bot avatar Aug 26 '24 12:08 facebook-github-bot

This pull request has been merged in facebook/Ax@36194d3cb752c388cd838a59c1bde983f9a1189b.

facebook-github-bot avatar Aug 26 '24 13:08 facebook-github-bot