Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Compute ground-truth optimization trace on BenchmarkProblem

Open esantorella opened this issue 1 year ago • 6 comments
trafficstars

Summary: This currently doesn't change behavior, but enables more flexibility by redefining Problem.get_ground_truth_opt_trace or BenchmarkRunner.get_Y_true. This is currently duplicative with the tracking metrics setup, which will be reaped in D61432000; these should be combined. This diff has both ways of computing the optimization trace running, along with an assertion that they give the same results.

Reviewed By: saitcakmak

Differential Revision: D61404056

esantorella avatar Aug 23 '24 20:08 esantorella

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 23 '24 20:08 facebook-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.40%. Comparing base (f1d2f88) to head (3d39c1e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2704   +/-   ##
=======================================
  Coverage   95.39%   95.40%           
=======================================
  Files         492      492           
  Lines       47920    47952   +32     
=======================================
+ Hits        45715    45747   +32     
  Misses       2205     2205           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 23 '24 20:08 codecov-commenter

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 23 '24 21:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 23 '24 21:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 24 '24 12:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 24 '24 12:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 24 '24 17:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 25 '24 20:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 27 '24 01:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D61404056

facebook-github-bot avatar Aug 27 '24 15:08 facebook-github-bot

This pull request has been merged in facebook/Ax@05fd370adc29d518194c00810f362503e2b72459.

facebook-github-bot avatar Aug 27 '24 16:08 facebook-github-bot