Ax icon indicating copy to clipboard operation
Ax copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Deterministic order of TorchModelBridge paramaters in _fit

Open ItsMrLin opened this issue 3 years ago • 2 comments

Summary: Make fitted TorchModelBridge parameters in a particular order.

Reviewed By: qingfeng10

Differential Revision: D39290841

ItsMrLin avatar Sep 06 '22 23:09 ItsMrLin

This pull request was exported from Phabricator. Differential Revision: D39290841

facebook-github-bot avatar Sep 06 '22 23:09 facebook-github-bot

Can we add a check for this in the unit test?

Balandat avatar Sep 06 '22 23:09 Balandat

Closed this PR since we realized instead of simple fix, this would impact many other code/tests. Will proceed with a different solution on the metric ordering issue to support BOPE.

ItsMrLin avatar Sep 19 '22 21:09 ItsMrLin