docker-maven-plugin icon indicating copy to clipboard operation
docker-maven-plugin copied to clipboard

Add support for MemorySwappiness

Open maxant opened this issue 3 years ago • 7 comments

Fix #1546

maxant avatar Apr 26 '22 19:04 maxant

@maxant : Thanks for the PR, Could you please address test failures?

rohanKanojia avatar Apr 27 '22 12:04 rohanKanojia

@rohanKanojia sorry for the wait :-)

Can I add a couple other properties into this PR or should I create a new issue? It would be more of the same for Init and MemoryReservation

maxant avatar May 20 '22 20:05 maxant

@rohanKanojia on the e2e tests I get this error:

https://app.circleci.com/pipelines/github/fabric8io/docker-maven-plugin/447/workflows/c5ab7a02-823e-4278-b401-dd8513241f29/jobs/4232?invite=true#step-103-1342

ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.2:war (default-war) on project dockerfile: 
Execution default-war of goal org.apache.maven.plugins:maven-war-plugin:2.2:war failed: Unable to load the mojo 'war' in the
 plugin 'org.apache.maven.plugins:maven-war-plugin:2.2' due to an API incompatibility:
 org.codehaus.plexus.component.repository.exception.ComponentLookupException: Cannot access defaults field of Properties

I don't really understand the error message - do you have any tips?

maxant avatar May 20 '22 20:05 maxant

Umm, not sure about e2e failures. Could you please try rebasing your branch and see if it gets resolved?

rohanKanojia avatar May 29 '22 12:05 rohanKanojia

@maxant: polite ping, are you still working on this?

rohanKanojia avatar Jun 24 '22 10:06 rohanKanojia

@maxant: polite ping, are you still working on this?

yes but with very low priority, unfortunately

maxant avatar Jun 26 '22 18:06 maxant