fabric8-analytics-vscode-extension icon indicating copy to clipboard operation
fabric8-analytics-vscode-extension copied to clipboard

[BUG] maven.executable.path not used anymore

Open rubensa opened this issue 1 year ago • 3 comments

Describe the bug This commit replaced maven.executable.path with mvn.executable.path, probably by mistake as maven.executable.path is the one used by the VSCode Maven extension.

To Reproduce Steps to reproduce the behavior:

  1. Without maven globally installed
  2. Set maven.executable.path in Settings
  3. Open pom.xml and click Open Vulnerability Report icon
  4. See error

Expected behavior The maven.executable.path setting is respected.

Logs

/bin/sh: 1: mvn: not found
manifest parse took 43 ms, found 13 deps
[Warn  - 8:05:45 AM] Component Analysis error. Error: Command failed: mvn --version
/bin/sh: 1: mvn: not found

fetch vulns took 5 ms

VSCode(please complete the following information):

  • OS: Ubuntu 22.04
  • VSCode version 1.85.0
  • Dependency Analytics Version 0.7.3

Additional context As a workaround you can set both mvn.executable.path and maven.executable.path settings but that is not the expected behavior.

rubensa avatar Dec 13 '23 07:12 rubensa