fabric8-analytics-vscode-extension icon indicating copy to clipboard operation
fabric8-analytics-vscode-extension copied to clipboard

Published 20 hours ago • verified publisher icon fabric8-analytics

fix: remove vscode-commons dependency

Open AkshayBhansali18 opened this issue 4 years ago • 5 comments
trafficstars

AkshayBhansali18 avatar Sep 14 '21 12:09 AkshayBhansali18

you want to remove https://github.com/fabric8-analytics/fabric8-analytics-vscode-extension/blob/762d2e30bc0f7e7a884dd4dd52225590f7ee69a3/package.json#L9-L11

fbricon avatar Oct 14 '21 13:10 fbricon

@mathur07 Can you please review this PR and get it merged. We need to prioritise this.

mohitsuman avatar Nov 04 '21 09:11 mohitsuman

@AkshayBhansali18 Some tests are failing, can you please push a fix commit.

mohitsuman avatar Nov 04 '21 10:11 mohitsuman

@AkshayBhansali18 There is an error around the record entry for the import. Can you please fix that.

mohitsuman avatar Nov 05 '21 09:11 mohitsuman

@AkshayBhansali18 Thanks for fixing the tests. Though the vsce package is failing, please have a look and make sure the CI is green so we can proceed with merge.

mohitsuman avatar Nov 11 '21 06:11 mohitsuman