Fable icon indicating copy to clipboard operation
Fable copied to clipboard

StringBuilder missing some Append overloads

Open jwosty opened this issue 3 years ago • 2 comments

Description

StringBuilder.Append is missing replacements for the float and decimal overloads. There may be more; those two are all I checked.

stringBuilder.Append (string someFloatValue)

Related information

  • Fable version: 3.1.4
  • Operating system: Windows 10.0.19043

jwosty avatar Dec 04 '21 07:12 jwosty

Yes, atm not all overloads of Append are supported. If you want to add more, it should be possible to just add the overload to the replacement here: https://github.com/fable-compiler/Fable/blob/1dfdd94c54375fb6c82bfff5ed93b0a031bfc0cc/src/fable-library/System.Text.fs#L3-L16

And tests here: https://github.com/fable-compiler/Fable/blob/1dfdd94c54375fb6c82bfff5ed93b0a031bfc0cc/tests/Main/StringTests.fs#L80-L88

alfonsogarciacaro avatar Dec 05 '21 02:12 alfonsogarciacaro

Yep, seems easy enough. Expect a PR soon

jwosty avatar Dec 11 '21 18:12 jwosty