django-admin-interface
django-admin-interface copied to clipboard
fabiocaccamo
Use static file as logo (if sets)
name: Pull request about: Submit a pull request for this project assignees: fabiocaccamo
Describe your changes Add possibility to use a server (maybe a default software house file) static logo as a logo
- Use
FilePathFieldfor absolute path and make it a relative path
Related issue closes #355
Checklist before requesting a review
- [x] I have performed a self-review of my code.
- [x] I have added tests for the proposed changes.
- [x] I have run the tests and there are not errors.
Codecov Report
Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 97.30%. Comparing base (
3293bea) to head (ee8c179). Report is 18 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| admin_interface/settings.py | 66.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 97.35% 97.30% -0.05%
==========================================
Files 38 39 +1
Lines 416 446 +30
==========================================
+ Hits 405 434 +29
- Misses 11 12 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 97.30% <96.15%> (-0.05%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@fabiocaccamo okay man, I'll provide the request changes soon 👍🏻 (I'm at work now)
@FraCata00 thanks for the PR, sorry for premature review, I was convinced it was ready for review, no rush ;)
@FraCata00 thanks for the PR, sorry for premature review, I was convinced it was ready for review, no rush ;)
It's okay 👌🏼, I'll mark it when it's ready for review Thanks for the review
@FraCata00 any update?
I'm sorry, I've been busy for my office..., I'll continue this week to PR, is this a problem?
@FraCata00 no problem, it was just to know if you were willing to continue working on this PR or not (in that case I would have closed the PR).
no problem, it was just to know if you were willing to continue working on this PR or not (in that case I would have closed the PR).
Oh yeah yeah, I'm interested in continuing the feature. Sorry for the late...
Hey just wanted to know if this PR is ready or not, I'd be interested in this feature
Sorry guys, I didn't have much time to continue the development, (due to work projects in my company)