Fabian Krüger

Results 83 comments of Fabian Krüger

HI @tan9 thank you for your contribution 🚀 ... and sorry for my bad responsiveness, I've been on vacation and got a pile of work. Your PR made me write...

Hi @tan9 I deleted my previous comment as I misunderstood your problem. My test was failing because of an invalid `artifactId` that I created but after fixing this dependencies to...

Hi @tan9 That's valuable insight, thank you! As we're mostly focussing on Boot applications at the moment we might just not have realized this problem. Actually, there's a good chance...

I added #516 to progress on this

> @fabapp2 I am glad that I can help. > > I am going to migrate tons of Java EE projects (100+) that are all tight to Spring Framework 3...

`MavenArtifactDownloader` should interpret relocations The upgrade in #1001 fails from 2.5 to 2.6 ```` org.openrewrite.maven.MavenDownloadingException: mysql:mysql-connector-java failed. Unable to download dependency mysql:mysql-connector-java:8.0.33. Response was 404 ```` [mysql:mysql-connector-java:8.0.33](https://mvnrepository.com/artifact/mysql/mysql-connector-java/8.0.33) is a relocation...

I spiked using the original `DefaultProjectParser` by creating an inline `org.gradle.api.Project` and implementing the called methods so that they return the data provide through [`GradleProjectData`](https://github.com/spring-projects-experimental/spring-boot-migrator/blob/main/sbm-gradle-tooling-model/model/src/main/java/org/springframework/sbm/gradle/tooling/GradleProjectData.java). But the `JavaCompile` class can't...

Thank you @shresthaujjwal for reporting and investigating. 🚀 After commenting on this I can assign it to you.

Hi @ammachado Thank you for keeping up the great work. 🚀 What doesn't work when you build the current `main` branch under Windows? "It works on my machine" 😬