dart icon indicating copy to clipboard operation
dart copied to clipboard

Android module with DH-3 enabled recompile `AndroidJavaCompile` when no changes occurred.

Open doniwinata0309 opened this issue 6 years ago • 4 comments

Hi, we are having a strange behaviour on the module that enable DH 3 recently. We are using multi module, let say I have module structure like this: Core --> Feature --> Appentry Assume making a changes on module Core, and run the first build (which will recompile Feature and Appentry module). But when we run a second build after this without any changes, the feature module recompile on this task com.android.build.gradle.tasks.AndroidJavaCompile. This should not be happen because the task still must be up to date because I making no changes on the code.

Checking from build-scan:


The task was not up-to-date because of the following reasons:
--
Input property 'source' file feature/build/generated/source/navigator/generalDebug has been removed.
Input property 'source' file feature/build/generated/source/navigator/generalDebug/com/myapp/android/feature/HensonNavigator.java has been removed.
Input property 'source' file feature/build/generated/source/navigator/generalDebug/com/myapp/android has been removed.
 

I believe that before running the second build, the file is still on that folder. But don't know why the task need to be recompile with that reasons. And if I run 3rd build, all of the task will be up-to-date. So it seems to be happen only after upper stream module being recompile.

Here are the details of our project: AGP: 3.3.2 Gradle version: 5.2.1 DH version: 3.1.2 Databinding: Enabled Proguard: Disabled Kotlin: Enabled

Do you know something about it ? please let me know if you need additional information. Any help would be appreciated. Thanks

doniwinata0309 avatar Mar 21 '19 09:03 doniwinata0309

Hi any update on this issue ?

doniwinata0309 avatar Jul 05 '19 06:07 doniwinata0309

hi @f2prateek do you know something about it ? it also happen on sync and slowing our build.

doniwinata0309 avatar Aug 06 '19 12:08 doniwinata0309

@ doniwinata0309, it is hard to see what is happening. Gradle is complicated and the only way to debug is to reproduce the issue.

If you can provide a sample and clear and short instructions to reproduce the issue, we can have a look. That's the only possible way to solve this issue.

S.

On Tue, Aug 6, 2019, 05:54 doniwinata0309, [email protected] wrote:

hi @f2prateek https://github.com/f2prateek do you know something about it ? it also happen on sync and slowing our build.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/f2prateek/dart/issues/238?email_source=notifications&email_token=AAN7PXPTHRZOSY3BIED7XVTQDFX6RA5CNFSM4HAD56M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VBDFA#issuecomment-518656404, or mute the thread https://github.com/notifications/unsubscribe-auth/AAN7PXKJ4VGNBWVVLGW366LQDFX6RANCNFSM4HAD56MQ .

stephanenicolas avatar Aug 06 '19 13:08 stephanenicolas

Hi @stephanenicolas , I am able to repro this on sample project. I just updated the AGP version, and gradle version. Please find my attachment for the sample project.dart-sample 2.zip

Here are the build scan from first build: https://scans.gradle.com/s/g77dlqxawwyjk/timeline?task=pwl6utdfccz42 This is clean build, so make sense why all task being compiled.

But running second build without changing anything, some task will need to rerun: https://scans.gradle.com/s/kdyhu7v63xle2/timeline?task=pwl6utdfccz42 with this reason:

The task was not up-to-date because of the following reasons:

Input property 'source' file module1/build/generated/source/navigator/debug has been removed. Input property 'source' file module1/build/generated/source/navigator/debug/com has been removed. Input property 'source' file module1/build/generated/source/navigator/debug/com/f2prateek has been removed. Let me know if you need additional information, Thanks.

doniwinata0309 avatar Aug 07 '19 05:08 doniwinata0309