gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Published 20 hours ago • verified publisher icon extrawurst

Select does not work on macOS

Open davidchisnall opened this issue 2 years ago • 9 comments

Describe the bug

Selecting multiple lines doesn't appear to work on macOS using the Apple Terminal. This appears to be to do with the terminal rather than the OS, since sshing to a FreeBSD machine from a Mac exhibits the same problem (but works when sshing from the Windows Terminal).

To Reproduce

  1. Run gitui in Apple Terminal
  2. Try to select multiple lines.

Context (please complete the following information):

  • OS/Distro + Version: Terminal Version 2.13 (447), macOS Ventura: 13.4.1
  • GitUI Version: 0.23.0

davidchisnall avatar Aug 15 '23 08:08 davidchisnall

TERM is set to xterm-color256, if this makes a difference.

davidchisnall avatar Aug 15 '23 08:08 davidchisnall

works for me on the vanilla apple terminal

extrawurst avatar Aug 18 '23 13:08 extrawurst

@extrawurst , what is the value of $TERM for you? I have made very few changes to the default configuration, but the changes I made were 10+ years ago and so I don't know what the defaults are anymore.

davidchisnall avatar Aug 23 '23 08:08 davidchisnall

xterm-256color

extrawurst avatar Aug 23 '23 12:08 extrawurst

Hmm, same as mine. Anything else I can try to help diagnose it? I'm using the version installed from Homebrew, no custom config.

davidchisnall avatar Aug 23 '23 12:08 davidchisnall

I simply cannot reproduce the problem. maybe you can make a screen recording to illustrate the problem

extrawurst avatar Aug 26 '23 13:08 extrawurst

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 15:03 stale[bot]

I have the same issue with macOS Terminal. When being in file diff view and trying to multi-select lines with Shift+Down or Shift+Up, the Shift key is ignored and selected line just moves up or down. The behavior is specific to macOS Terminal, since it works perfectly in terminal emulations of VSCode and IntelliJ (on macOS).

I can't remember changing much in Terminal settings besides the colors, so they should be quite the defaults.

Rpinski avatar Jun 11 '24 07:06 Rpinski

Ah sorry, I found this related issue and explicitly defining the key strokes in Terminal settings has fixed it:

https://github.com/extrawurst/gitui/issues/959

Rpinski avatar Jun 11 '24 08:06 Rpinski