serve-index
serve-index copied to clipboard
expressjs
code style: semicolons or no?
Some lines have them. Some lines don't. Some lines have extra.
I don't care which way you want it (though for myself I prefer to follow the language spec and have them), but I assume that it should be one or the other and not 50/50.
I'd be happy to PR with or without if you let me know which you prefer.
This project was just a semicolon style, but all Express.js project are changing to StandardJS style. Only lines changes since that decision have been changed to StandardJS style otherwise all PSs will no longer merge if you suddenly removed all semicolons.
If you have a method to change it to StandardJS but not leave all the open PRs in an un-mergable state, please let me know!
I started going through the PRs and it looks like several have been stale and I closed them. Give me a couple days to look through the PRs and perhaps they'll all be closed, which would leave open the ability to make a PR to change everything to StandardJS if you want to 👍 (ensure it validates the style in CI -- just copy exactly how all the other Express.js projects enforce their StandardJS styling).
I was able to get through just about all of them this weekend. At least one that was not closed out got s new pr made that will merge.
With the work week starting I'll see how much I can fit in, but may need until next weekend to get them all either merged or closed out.
bump
If there's anything you can farm out to me - merging, testing, etc - I'd be happy to do it. I strongly believe that this module has potential to go from good to great.