eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[eas-cli] Use credentials types from eas-build-job where possible

Open sjchmiela opened this issue 1 year ago • 5 comments

Why

I've noticed we have two very similar types in eas-build and eas-cli. The types in eas-cli are just intermediate — in the end, when we hand off the build request to www we change them into the eas-build ones.

Wouldn't it be nice if we used the target types from the beginning?

How

Removed TargetCredentials in favor of Ios.TargetCredentials. IosCredentials in favor of Ios.BuildCredentials. Basically, that's it!

Also made some minor change to credentialsJson/types so that less types are exported so we are forced to try to use the eas-build-job ones.

Test Plan

TODO

sjchmiela avatar Jan 19 '24 19:01 sjchmiela

Size Change: -2.04 kB (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB -2.04 kB (0%)

compressed-size-action

github-actions[bot] avatar Jan 19 '24 20:01 github-actions[bot]

/changelog-entry chore Migrate to using credentials types from eas-build-job where possible

sjchmiela avatar Jan 19 '24 21:01 sjchmiela

✅ Thank you for adding the changelog entry!

github-actions[bot] avatar Jan 19 '24 21:01 github-actions[bot]

Codecov Report

Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.10%. Comparing base (8ea0579) to head (d8e8060). Report is 729 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/ios/prepareJob.ts 20.00% 4 Missing :warning:
...s/eas-cli/src/credentials/credentialsJson/utils.ts 0.00% 1 Missing :warning:
...-cli/src/credentials/ios/IosCredentialsProvider.ts 66.67% 1 Missing :warning:
...ctions/SetUpBuildCredentialsFromCredentialsJson.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2191      +/-   ##
==========================================
+ Coverage   54.10%   54.10%   +0.01%     
==========================================
  Files         516      516              
  Lines       18795    18793       -2     
  Branches     3769     3769              
==========================================
  Hits        10167    10167              
+ Misses       8607     8605       -2     
  Partials       21       21              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 19 '24 21:01 codecov[bot]