eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[ENG-4579] convert eas-cli to ESM

Open dsokal opened this issue 3 years ago • 2 comments
trafficstars

Checklist

  • [ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests.

How

How did you build this feature or fix this bug and why?

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

dsokal avatar Jul 07 '22 07:07 dsokal

ENG-4579 Convert eas-cli to esm

Screenshot 2022-04-07 at 15.26.32.png

We can't convert a bunch of deps in eas-cli because it's not an ESM. It seems that it should be possible to convert eas-cli now

https://github.com/oclif/core/issues/130

https://github.com/typhonjs-oclif-scratch/test-cli-modern/tree/main/src

linear[bot] avatar Jul 07 '22 07:07 linear[bot]

Size Change: +778 kB (+3%)

Total Size: 25.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 25.9 MB +778 kB (+3%)

compressed-size-action

github-actions[bot] avatar Jul 07 '22 07:07 github-actions[bot]

Closing this for now

dsokal avatar Sep 06 '22 12:09 dsokal