java icon indicating copy to clipboard operation
java copied to clipboard

Numbers: Cars, Assemble! Refactored unit tests in a way that ignores machine epsilon

Open izzettunc opened this issue 3 years ago • 0 comments

pull request

Background:

I am creating this pull request as one of my students stumble upon a test case where it failed due to machine epsilon and in this pr, I have refactored the unit tests in a way that it ignores machine epsilon as i think it's too early to challenge students with this kind of errors and it was probably unintentional for this particular exercise.

Reproduction:

While this issue can be avoided by calculating productionRatePerHour function as follows: defaultProductionRate * speed * successRate(speed)

The issue can be reproduced by calculating productionRatePerHour function as follows which confuses students: defaultProductionRate * successRate(speed) * speed


Reviewer Resources:

Track Policies

izzettunc avatar Aug 29 '22 13:08 izzettunc