markdown-it-py icon indicating copy to clipboard operation
markdown-it-py copied to clipboard

⬆️ UPGRADE: Allow linkify-it-py v2

Open hukkin opened this issue 3 years ago • 3 comments

hukkin avatar May 09 '22 00:05 hukkin

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@032c742). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #218   +/-   ##
=========================================
  Coverage          ?   96.08%           
=========================================
  Files             ?       62           
  Lines             ?     3221           
  Branches          ?        0           
=========================================
  Hits              ?     3095           
  Misses            ?      126           
  Partials          ?        0           
Flag Coverage Δ
pytests 96.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 09 '22 00:05 codecov[bot]

Heya, could you briefly outline what the changes in v2 are and how it might affect parsing?

chrisjsewell avatar May 09 '22 15:05 chrisjsewell

It seems to be a port of linkify-it 4.0.0 (changelog here) which makes a couple fixes and adds a new method. Doesn't seem like a breaking change despite the major version bump. Also all tests pass so :shrug: seems good to me.

hukkin avatar May 09 '22 16:05 hukkin

better late than never 😅

chrisjsewell avatar Feb 22 '23 04:02 chrisjsewell