jupyter-cache icon indicating copy to clipboard operation
jupyter-cache copied to clipboard

Published 20 hours ago • verified publisher icon executablebooks

Allow for per notebook/cell execution timeout settings

Open chrisjsewell opened this issue 5 years ago • 10 comments

Stored in metadata, that is implemented by the executor

Also relates to #5

chrisjsewell avatar Mar 13 '20 15:03 chrisjsewell

Hmm - I suspect that the nbformat issue will take some time to resolve, so I wonder if we should just go with @AakashGfude 's proposed metadata spec, and if Jupyter adopts an "official" one then we can support that as well. Some folks have reported this bug in Jupyter Book, so I think we should just go with a short-term solution. WDYT?

choldgraf avatar May 19 '20 22:05 choldgraf

Yeh go for it. Just make sure that an issue is still open for the "long-term" solution, so we don't forget

chrisjsewell avatar May 19 '20 22:05 chrisjsewell

cc @AakashGfude , in case you have a moment to wrap up your PR on this one (see above comment for context)

choldgraf avatar May 20 '20 20:05 choldgraf

ooh. cool. I will wrap this up as soon as I can.

AakashGfude avatar May 21 '20 11:05 AakashGfude

@AakashGfude awesome, thanks...we've had like 3 bug reports opened about this particular issue already 😆

choldgraf avatar May 21 '20 14:05 choldgraf

oops. sorry I missed this one. The PRs in Myst-NB and jupyter-cache were ready to be merged from my side. Additionally, I will try and add a test for this in Myst-NB.

AakashGfude avatar May 22 '20 09:05 AakashGfude

@choldgraf have added test-cases. Note that the Tests in Myst-NB will fail, until the PR in jupyter-cache is merged. If you have time, will you be able to add the necessary additions for execution_timeout in jupyter-book? Else I can do it some time during the weekend.

AakashGfude avatar May 22 '20 10:05 AakashGfude

@AakashGfude for sure, I'll figure out how to get it into jupyter book

choldgraf avatar May 22 '20 17:05 choldgraf

any update on this? I'm running into the same timeout issue as #613

poldrack avatar Jul 16 '20 15:07 poldrack

I believe that if you add notebook-level metadata to a page then it should work w/ the latest version of jupyter-cache: https://jupyter-cache.readthedocs.io/en/latest/using/api.html?highlight=timeout#timeout

however we have not yet documented this in Jupyter Book! @poldrack if this works for you, can you let us know and we can try to add docs for it in JB?

choldgraf avatar Jul 16 '20 18:07 choldgraf