sql-statement-builder icon indicating copy to clipboard operation
sql-statement-builder copied to clipboard

Published 20 hours ago • verified publisher icon exasol

Refactor ValueTableVisitor

Open kaklakariada opened this issue 4 years ago • 1 comments

Refactor the ValueTableVisitor interface like ColumnsDefinitionRenderer (#102) or BooleanExpressionVisitor (#100).

kaklakariada avatar Sep 28 '21 07:09 kaklakariada

I gave this one a shot and realized that, while with the previous refactorings the classes got smaller, we lost runtime efficiency and diluted the design (e.g. where SoC is broken now). So it looks like the whole visitor structure will need a clean redesign. Preferably done in pair programming mode.

redcatbear avatar Apr 14 '23 09:04 redcatbear

We don't have the capacity to implement this at the moment.

kaklakariada avatar Jun 07 '24 09:06 kaklakariada