ethermint icon indicating copy to clipboard operation
ethermint copied to clipboard

Support unprotected txs

Open mdehoog opened this issue 2 years ago • 2 comments

Description

There is a flag for enabling pre-EIP-155 transactions: https://github.com/evmos/ethermint/blob/07cf2bd2b1ce9bdb2e44ec42a39e7239292a14af/server/flags/flags.go#L65

Currently that flag is not read when creating the configuration, which this PR fixes.


For contributor use:

  • [x] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. (minor bug fix)
  • [x] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [x] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [x] Re-reviewed Files changed in the Github PR explorer

For admin use:

  • [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • [ ] Reviewers assigned
  • [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

mdehoog avatar Jul 25 '23 09:07 mdehoog

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

github-actions[bot] avatar Sep 09 '23 00:09 github-actions[bot]

cc @Vvaradinov @MalteHerrmann

mdehoog avatar Sep 11 '23 20:09 mdehoog