Andrew Williamson

Results 97 comments of Andrew Williamson

> * add the `addon-id` to the manifest if not already there (in the `build` function? in `getValidatedManifest`?) if it's either provided via command line arg or in `.web-extension-id`. Requiring...

> When we submit an add-on for the first time, without the ID in the manifest, IIRC AMO will inject it automagically. Can we detect that in `web-ext sign` and...

Some connection with #2491 here - because we can't really assume that the `sign` command will wait for a signed xpi and we only save the ID then.

> > I guess my assumption was wrong that `web-ext` would implement that behaviour on the back of the MV3 requirements. > > MV3 manifests must have an extension ID....

From the discussion above and offline, it seems like there is no immediate plan to add the id to the manifest automatically, and #2511 adds messaging that instructs the developer...

From the log it's > The number of GET/POST parameters exceeded settings.DATA_UPLOAD_MAX_NUMBER_FIELDS. {"EnvVersion":"2.0", "Fields":{…}, "Hostname":"..., "Logger":"http_app_addons", "Pid":9, "Severity":3, "Timestamp":1.6939106072952323E18, "Type":"django.security.TooManyFieldsSent"} which matches the scaling (2-4 works but 10 doesn't) -...

options here include: - increase `DATA_UPLOAD_MAX_NUMBER_FIELDS` somewhat - though not too high as it's limited for a reason - return a nice error when the number of versions exceeds `DATA_UPLOAD_MAX_NUMBER_FIELDS...

`web-ext` currently works by zipping `--source-dir` first and uploading that so we should consider how another source directory would work in that workflow. If it's machine-generated code that it's very...

@rpl @willdurand @Rob--W can I get your thoughts on how this feature should work?

see https://github.com/mozilla/addons/issues/8690 for a screenshot and some background