donate-button icon indicating copy to clipboard operation
donate-button copied to clipboard

Proper cloudinary flags

Open markulrich opened this issue 3 years ago • 4 comments

The cover and logo do not use f_auto,q_auto like they should

markulrich avatar May 27 '22 19:05 markulrich

See https://cloudinary.com/documentation/image_optimization

markulrich avatar Jul 13 '22 18:07 markulrich

https://github.com/everydotorg/donate-button/blob/main/packages/donate-button-next/src/components/widget/api/get-nonprofit-info.ts#L8

markulrich avatar Jul 13 '22 18:07 markulrich

Will take a look at this tomorrow.

nate-j5 avatar Jul 14 '22 01:07 nate-j5

Adding some details, while currently the getCloudinaryUrl will return a string like https://res.cloudinary.com/everydotorg/image/upload/profile_pics/ftwf0qtym2defaahzfrh (22 kb jpeg on my machine) we want it to return https://res.cloudinary.com/everydotorg/image/upload/f_auto,q_auto/profile_pics/ftwf0qtym2defaahzfrh (13 kb avif on my machine)

markulrich avatar Jul 19 '22 18:07 markulrich