EventFlow icon indicating copy to clipboard operation
EventFlow copied to clipboard

Published 20 hours ago • verified publisher icon eventflow

Make serialization scheme more generic

Open tedvanderveen opened this issue 5 years ago • 8 comments

At the moment, quite a few implementation in the library are tightly coupled to JSON de/serialization. For my current project, I need to use a more compact binary serialized scheme. This PR makes event serialization scheme more generic, and allows for dropping in binary serialization.

This adds support for using for example Protobuf of BSON serialization of events.

tedvanderveen avatar Jun 02 '20 14:06 tedvanderveen

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 02 '20 14:06 CLAassistant

Hi @rasmus, looks like this PR is ready for review (AppVeyor is still running at the moment). There should be no changes to the library's existing public APIs. Looking forward to your feedback!

tedvanderveen avatar Jun 03 '20 20:06 tedvanderveen

@rasmus looks like appveyor timed out, can you restart the build please?

tedvanderveen avatar Jun 03 '20 20:06 tedvanderveen

@rasmus looks like appveyor timed out, can you restart the build please?

@rasmus added a missing newline at end of a file, to trigger new build ;-)

tedvanderveen avatar Jun 04 '20 07:06 tedvanderveen

@rasmus the appveyor build timed out again (after 1 hour). Does this happen more often? Can you see more details maybe on what causes it to time out?

tedvanderveen avatar Jun 04 '20 09:06 tedvanderveen

Normally it doesn't, I'll have a look this evening

rasmus avatar Jun 04 '20 09:06 rasmus

Usually its the RabbitMQ tests that die, this seems a bit odd.

rasmus avatar Jun 07 '20 16:06 rasmus

While I do like the cleanup, this change has several braking changes thus we'll have to wait until a major release.

While 0.x is technically a beta version, many rely in the current APIs and I try not to do any API breaking changes. I know that there are plenty companies out there that have implemented their own event store to better suit their infrastructure.

rasmus avatar Jun 07 '20 16:06 rasmus

Hello there!

We hope this message finds you well. We wanted to let you know that we have noticed that there has been no activity on this pull request for the past 90 days, which makes it a stale pull request.

As a result, we will be closing this pull request within the next seven days. If you still think this pull request is necessary or relevant, please feel free to update it or leave a comment within the next seven days.

Thank you for your contributions and understanding.

Best regards, EventFlow

github-actions[bot] avatar Apr 08 '23 13:04 github-actions[bot]

Hello there! I'm a bot and I wanted to let you know that your pull request has been closed due to inactivity after being marked as stale for seven days. If you believe this was done in error, or if you still plan to work on this pull request, please don't hesitate to reopen it and let us know. We're always happy to review and merge high-quality contributions. Thank you for your interest in our project! Best regards, EventFlow

github-actions[bot] avatar Apr 16 '23 09:04 github-actions[bot]