blind-jump-portable icon indicating copy to clipboard operation
blind-jump-portable copied to clipboard

Corrected Italian translation

Open mikyll opened this issue 3 years ago • 4 comments

I've corrected some entry of the Italian translation.

I have just one doubt left, since I can't find the reference inside the game: what is the meaning of the "shell" and what are you referring to? (line 45 of file strings/english.txt)


PS: the game is amazing and I love it! :)

mikyll avatar Oct 19 '22 23:10 mikyll

@mikyll I mean shells in this context: https://en.wikipedia.org/wiki/Shell_(projectile)

evanbowman avatar Oct 20 '22 00:10 evanbowman

Thank you for your changes! Before merging the pull request, I will need to test the game after changing the translation, mainly to make sure that the text still fits on the screen. I'll try to work on it soon, but it may be a couple of days before I can get to it

evanbowman avatar Oct 20 '22 00:10 evanbowman

@evanbowman I think in that case the best way to translate shells is munizioni (which I prefer rather than cartucce because the latter refers to just small calibers and I also think it sounds worse), however I've corrected it and made other little changes which I didn't notice while editing the first time.

Feel free to let me know if there's any problem or some entry that doesn't fit anymore in the game, I'd love to help you out :)

mikyll avatar Oct 20 '22 12:10 mikyll

Thanks for reviewing and for everyone's work on this! There are just one or two places in the file where trailing whitespace was added to or removed from some lines. Understand that the code will recenter text based on the length of strings in the translation, so newly added trailing spaces may result in changes to text alignment. Similarly, if any trailing whitespace was removed from the file, some text may end up concatenated with other text without proper spacing. I didn't see too many issues in the diff, maybe one or two lines. I'll take another look later. Then, I'll merge the translation and post an updated rom.

evanbowman avatar Nov 10 '22 12:11 evanbowman