libhttpserver icon indicating copy to clipboard operation
libhttpserver copied to clipboard

[BUG] Test coverage for -DCASE_INSENSITIVE is lacking.

Open bcsgh opened this issue 2 years ago • 0 comments
trafficstars

Prerequisites

  • [X] Put an X between the brackets on this line if you have checked that your issue isn't already filed: https://github.com/search?l=&q=repo%3Aetr%2Flibhttpserver&type=Issues

Description

Some digging around for other reason shows that http_endpoint::operator< is unconditionally case-insensitive. This strongly implies that there are gaps in the test suite relating to builds with -DCASE_INSENSITIVE.

Steps to Reproduce

Play around with this: https://github.com/etr/libhttpserver/pull/309/commits/518a966890d595b5889dd9966f488ac65adda319

Expected behavior: Test coverage both with and withou -DCASE_INSENSITIVE and the cases where they differ.

Actual behavior: A test I added for one case surfaced a bug.

Versions

Current master.

bcsgh avatar Apr 06 '23 05:04 bcsgh