swarm icon indicating copy to clipboard operation
swarm copied to clipboard

Published 20 hours ago • verified publisher icon ethersphere

Update to go-ethereum v1.9.11, fix log incompatibility

Open p4u opened this issue 5 years ago • 2 comments

System information

Swarm version: 0.5.7 and Master OS & Version: Linux

Expected behaviour

Use last go-ethereum version v1.9.11

Actual behaviour

go.mod points to old go-ethereum v1.9.2

If a project uses swarm 0.5.7 and go-ethereum v1.9.11 as go-mod imported packages, the build breaks due a swarm incompatibility issue

Steps to reproduce the behaviour

go get -u github.com/ethereum/go-ethereum

build swarm code

Backtrace

github.com/ethersphere/[email protected]/swap/swap.go:131:9: undefined: "github.com/ethereum/go-ethereum/log".RotatingFileHandler

p4u avatar Feb 28 '20 08:02 p4u

Looks like it was mainly removed due to a data race condition.

chadsr avatar Mar 05 '20 20:03 chadsr

ping! this is a quite important issue IMO

p4u avatar Mar 10 '20 08:03 p4u