ethereumjs-monorepo
ethereumjs-monorepo copied to clipboard
Worker threads/signature verification pool tests
A vibe coded experiment with worker threads for ecrecover
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 84.80%. Comparing base (a819fe9) to head (c8f9c66).
:warning: Report is 9 commits behind head on master.
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| block | 87.81% <ø> (ø) |
|
| blockchain | 89.37% <ø> (ø) |
|
| common | 96.75% <ø> (ø) |
|
| evm | 72.39% <ø> (ø) |
|
| mpt | 90.05% <ø> (+0.30%) |
:arrow_up: |
| statemanager | 80.21% <ø> (ø) |
|
| static | 99.77% <ø> (ø) |
|
| tx | 88.35% <ø> (ø) |
|
| util | 89.62% <ø> (ø) |
|
| vm | 57.32% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Looks super-great! Love that this is already so structurally cleanly integrated, so that we can likely keep/merge even if we do not follow up on this directly.
At least I would ad hoc suggest - that we do permanently keep such a code struct as test setup, so that we can do more easily do future experiments with other code parts and have the outer stuff already in place. 🤩 Maybe for this we could just move over the "production" code from src to test as well? But just thinking about loud! 😄
Two small direct nice-to-have suggestions:
- Maybe worth to put some of your findings directly into some short dev doc section, maybe first-round in VM
DEVELOPER.md(and potentially shift around later on, but also did not have such a close look). - There is this dedicated benchmark structure in Vitest https://vitest.dev/guide/features.html#benchmarking, might also be nice to directly apply here, also file-name-wise, but on the other hand fully discard if this side-tracks you or is not practicable
@holgerd77 do you feel this is worth bringing over to a merge-able state (looks like it's close enough!) ?