ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Replace `ethers` with `viem` in vm examples/tests

Open acolytec3 opened this issue 7 months ago • 1 comments

ethers currently is using an older version of @noble/hashes (v1.3.2) which is causing some duplication of versions of @noble/hashes in our monorepo.

ethers is only being used in vm for some ABI encoding/decoding utilities in 2 examples and one test so this replaces it with viem which has no dependencies and provides basically drop-in replacements for those tools.

Note, the robots wrote the actual translations of these functions and I reviewed/edited/tightened things up.

acolytec3 avatar Apr 21 '25 16:04 acolytec3

Codecov Report

:x: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 84.82%. Comparing base (a819fe9) to head (2423064). :warning: Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 87.81% <ø> (ø)
blockchain 89.37% <ø> (ø)
common 96.75% <ø> (ø)
evm 72.39% <ø> (ø)
mpt 90.36% <ø> (+0.61%) :arrow_up:
statemanager 80.21% <ø> (ø)
static 99.77% <ø> (ø)
tx 88.35% <ø> (ø)
util 89.62% <ø> (ø)
vm 57.42% <0.00%> (+0.10%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 21 '25 16:04 codecov[bot]

I generally guess we can take this in. I don't want to take in this very old package-lock.json though and am a bit afraid to re-generate myself after all the hazzle yesterday. So keeping this open for now (but everyone who is capable of a descent package-lock.json update feel free to update and merge).

holgerd77 avatar Aug 28 '25 09:08 holgerd77