ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon ethereumjs

Tx: Class names not fully consistent yet

Open holgerd77 opened this issue 1 year ago • 3 comments

Following tx type class names still needs shortening from Transaction to Tx to be consistent with the other class names. 🙂

  • AccessList2930Transaction
  • EOACode7702Transaction

Correct example: FeeMarketEIP1559Transaction -> FeeMarket1559Tx

holgerd77 avatar Oct 07 '24 14:10 holgerd77

I will address this among the refactor PR(s). (Might break up the refactor in multiple PRs)

jochem-brouwer avatar Oct 07 '24 15:10 jochem-brouwer

Ok, interesting how we missed this one, because you are right, for EIP1559 and for EIP4844 the names are correct :thinking:

jochem-brouwer avatar Oct 07 '24 20:10 jochem-brouwer

It's super easy to miss out on these renamings, there is so much stuff all over the place

holgerd77 avatar Oct 08 '24 12:10 holgerd77