ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Client: Failing engine-cancun Hive Tests: "ForkchoiceUpdatedV3 To Request Shanghai/Cancun Payload"

Open holgerd77 opened this issue 1 year ago • 3 comments

We have several Hive engine tests failing, see e.g. here as some latest run.

Picking out the following failing tests:

grafik

These should be (I guess?) a somewhat easy fix, seems there is mainly the error code for some scenario wrong:

"FAIL (ForkchoiceUpdatedV3 To Request Shanghai Payload, Null Beacon Root): Expected error code on EngineForkchoiceUpdatedV3: want=-38003, got=-32602"

This might also be easiest to fix optimistically, so not to directly validate by setting up Hive (at least if one has not the setup locally and easily available) but just look at the scenario, give this a fix and see on next Hive run if things pass.

Note that there are more failing tests. Just picking out these ones to have one place for one type of failure to work on and eventually discuss and exchange.

holgerd77 avatar Sep 20 '24 10:09 holgerd77

I would not suggest to open a PR without running these tests locally in hive. When I get to this, I will write a setup guide here.

jochem-brouwer avatar Sep 20 '24 17:09 jochem-brouwer

Hmm, honestly: why not? Most of our bug fixing is done fully independent from Hive. And when Hive points to some misbehavior and we can confirm for ourselves this is misbehavior we can very well fix that without all the Hive setup?

holgerd77 avatar Sep 23 '24 13:09 holgerd77

I have started on this (and have just assigned myself)

jochem-brouwer avatar Sep 25 '24 13:09 jochem-brouwer