Monorepo: Nightly VM Tests fail

[holgerd77]

Our nightly VM tests fail for weeks now, see e.g. here.

It would really be good, if someone would look into that. Might be a small-ish thing (fails directly on installation with some dependency resolution problem).

[jochem-brouwer]

Tests now run, but we have a blockchain test runner problem, e.g. job https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/10428382061

Fork config: BerlinToLondonAt5

2024-08-17T02:57:33.8041160Z Errors thrown in file: TransitionTests/bcBerlinToLondon/londonUncles.json test: londonUncles_BerlinToLondonAt5:
2024-08-17T02:57:33.8044471Z 	Error: calcNextBaseFee() can only be called with EIP1559 being activated (block header number=3 hash=0x8dee0dbbf4b9a228734395e0be8021808664d8a9ee02e9e7f12d6067d260e476 hf=berlin baseFeePerGas=none)
2024-08-17T02:57:33.8047137Z 	Error: value for 0x0eab710deceb909e553d95bcc14065cc81a6197f334cb545065f7280e634a15c not found in DB
2024-08-17T02:57:33.8048840Z 	Error: value for 0x6148adba5f62e3b924cdc1630cd7b9b1d52ef623eefa395f9761c670980ec774 not found in DB
2024-08-17T02:57:33.8050240Z 	Error: value for 0x574dfd05aff119f7869aae03a845921a77e109c2b2c948d10f07417cb82fd1d8 not found in DB
2024-08-17T02:57:33.8051285Z 	Error: value for 0x575e520c911fcad10b7d437f68256c760e91c81b697bd70afd83c0ea39838fbd not found in DB
2024-08-17T02:57:33.8052925Z 	Error: value for 0xc0570502136f2b0d3f1bf76b22e99614b9e48ede6c478ffc8408d3ecb4510a60 not found in DB
2024-08-17T02:57:33.8054642Z 	Error: value for 0x9b973bf69e337207759cda9905a2b8c498430f2cd8bae9a4a6b7f3cc7e439f14 not found in DB
2024-08-17T02:57:33.8055684Z 	correct last header block
2024-08-17T02:57:33.8057692Z 	Error: calcNextBaseFee() can only be called with EIP1559 being activated (block header number=3 hash=0x8dee0dbbf4b9a228734395e0be8021808664d8a9ee02e9e7f12d6067d260e476 hf=berlin baseFeePerGas=none)
2024-08-17T02:57:33.8060032Z 	Error: value for 0x0eab710deceb909e553d95bcc14065cc81a6197f334cb545065f7280e634a15c not found in DB
2024-08-17T02:57:33.8061134Z 	Error: value for 0x6148adba5f62e3b924cdc1630cd7b9b1d52ef623eefa395f9761c670980ec774 not found in DB
2024-08-17T02:57:33.8062029Z 	Error: value for 0x574dfd05aff119f7869aae03a845921a77e109c2b2c948d10f07417cb82fd1d8 not found in DB
2024-08-17T02:57:33.8062908Z 	Error: value for 0x575e520c911fcad10b7d437f68256c760e91c81b697bd70afd83c0ea39838fbd not found in DB
2024-08-17T02:57:33.8063778Z 	Error: value for 0xc0570502136f2b0d3f1bf76b22e99614b9e48ede6c478ffc8408d3ecb4510a60 not found in DB
2024-08-17T02:57:33.8064642Z 	Error: value for 0x9b973bf69e337207759cda9905a2b8c498430f2cd8bae9a4a6b7f3cc7e439f14 not found in DB
2024-08-17T02:57:33.8065236Z 	correct last header block

Will take a look ASAP

[acolytec3]

No doubt related to all the common refactor stuff we've done lately.

[holgerd77]

Just dropping here the command to run this test in isolation:

npm run test:blockchain -- --file='londonUncles.json' --fork=BerlinToLondonAt5

[holgerd77]

Did some first debugging, so this is the code in blockchain affected/involved:

So, when run through the debugger the first call of this passes with a block with number 5n given, then on second call a block with number 4n is passed but this then (falsely I guess) also already has a HF of London assigned and this goes then into parentHeader.calcNextBaseFee() where the berlin thing is triggered.

I wonder if this might have something todo with our missing deep copy in Common (see #3572), might be worth to first add (since we need to do anyhow) and see if this helps.

[jochem-brouwer]

Failing forks:

BerlinToLondonAt5, HomesteadToDaoAt5, Istanbul, MuirGlacier

[jochem-brouwer]

All should be fixed in https://github.com/ethereumjs/ethereumjs-monorepo/pull/3633