ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Util: treeshaking tasks

Open ScottyPoi opened this issue 1 year ago • 6 comments

Util treeshaking task cleanup from #3560

  • withdrawal.ts
    • Withdrawal static constructors extracted to functions
  • requests.ts renamed request.ts
    • static constructors extracted to functions
      • WithdrawalRequest
      • ConsolidationRequest
      • DepositRequest

ScottyPoi avatar Aug 14 '24 17:08 ScottyPoi

In-between feedback: this looks good so far

holgerd77 avatar Aug 15 '24 08:08 holgerd77

In-between feedback: this looks good so far

Ran out of time before the weekend. Will finish this up today

ScottyPoi avatar Aug 20 '24 16:08 ScottyPoi

Codecov Report

Attention: Patch coverage is 71.05263% with 33 lines in your changes missing coverage. Please review.

Project coverage is 20.69%. Comparing base (4470cc3) to head (2c368ea). Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain 84.92% <ø> (?)
client ?
common 89.68% <ø> (?)
devp2p 0.00% <ø> (?)
genesis 0.00% <ø> (?)
tx ?
util 71.45% <71.05%> (?)
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 23 '24 19:08 codecov[bot]

Please update the example embeddings in the util docs and any other package docs that have modified examples from this PR. Also see here for more details.

am1r021 avatar Aug 26 '24 18:08 am1r021

Can this be finalized so that we can merge?

holgerd77 avatar Aug 27 '24 09:08 holgerd77

changes addressed. ready for re-review

ScottyPoi avatar Aug 27 '24 18:08 ScottyPoi

Nice, looks good! 🙂

holgerd77 avatar Sep 02 '24 11:09 holgerd77