ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

EVM: fix EOF failures found by fuzzer

Open jochem-brouwer opened this issue 1 year ago • 2 comments

This PR fixes the EOF container validation divergences found by the fuzzer, see https://github.com/ipsilon/eof/issues/146

WIP

jochem-brouwer avatar Aug 07 '24 18:08 jochem-brouwer

Can this be closed?

holgerd77 avatar Oct 09 '24 10:10 holgerd77

No, actually I should import the changes in this branch for fixes for the EOF test fixtures (or use this PR for it).

jochem-brouwer avatar Oct 09 '24 10:10 jochem-brouwer

Codecov Report

Attention: Patch coverage is 49.49495% with 50 lines in your changes missing coverage. Please review.

Project coverage is 75.63%. Comparing base (100d77d) to head (5852681). Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.23% <ø> (ø)
client 73.64% <ø> (ø)
common 89.93% <100.00%> (+0.04%) :arrow_up:
devp2p 71.95% <ø> (ø)
evm 64.72% <45.05%> (-0.22%) :arrow_down:
genesis 100.00% <ø> (ø)
mpt 52.09% <ø> (-0.22%) :arrow_down:
rlp 95.11% <ø> (ø)
statemanager 67.81% <ø> (ø)
tx 76.56% <ø> (ø)
util 72.81% <ø> (ø)
vm 57.30% <ø> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 05 '24 17:12 codecov[bot]

This currently passes the blockchain/state tests, what is left to do is to verify the container validator tests also.

jochem-brouwer avatar Dec 05 '24 23:12 jochem-brouwer

Problem with tests related to Prague, not Osaka: EXTCODEHASH on an empty account (with 7702 activated), test:

npm run test:blockchain -- --fork=Osaka --dir=../fixtures/fixtures/blockchain_tests/osaka/eofwrap/stBadOpcode --test=invalidAddr_d31g0v0_Cancun

Fix:

https://github.com/ethereumjs/ethereumjs-monorepo/pull/3568/commits/2e0f9c5a52f56a0a3e2078e1f0c76279c820af80

jochem-brouwer avatar Dec 06 '24 17:12 jochem-brouwer

Passes https://github.com/ethereum/execution-spec-tests/releases/tag/eip7692%40v2.1.0, ready for merge :)

jochem-brouwer avatar Dec 09 '24 16:12 jochem-brouwer