ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

evm: move map -> array for opcodes/gas

Open jochem-brouwer opened this issue 1 year ago • 3 comments

This PR changes the internal Opcodes / Dynamic Gas type from Map -> Array. Array lookups seem faster than Map.

Also super small code cleanup, such as removing unused arguments (_common)

jochem-brouwer avatar Jul 22 '24 17:07 jochem-brouwer

I add blocked/do-not-merge labels so that this does not get accidentally merged.

For context see #work channel discussion.

holgerd77 avatar Jul 22 '24 18:07 holgerd77

Ah right, sorry, should have done that also. Thanks for adding :smile: :+1:

jochem-brouwer avatar Jul 22 '24 18:07 jochem-brouwer

Have also marked as draft!

jochem-brouwer avatar Jul 22 '24 18:07 jochem-brouwer

I think we might want to close here and not act upon this?

holgerd77 avatar Oct 09 '24 10:10 holgerd77

Yep!

jochem-brouwer avatar Oct 09 '24 11:10 jochem-brouwer