ethereumjs-monorepo
ethereumjs-monorepo copied to clipboard
ethereumjs
WIP: implement EIP-5806
See https://github.com/Amxx/EIP-5806/tree/main to track the other implementation effort.
Codecov Report
Attention: Patch coverage is 46.05263% with 41 lines in your changes are missing coverage. Please review.
Project coverage is 86.54%. Comparing base (
5e3cfdd) to head (e40a37c).
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| block | 88.43% <ø> (ø) |
|
| blockchain | 91.61% <ø> (ø) |
|
| client | 84.89% <37.50%> (-0.01%) |
:arrow_down: |
| common | 98.44% <100.00%> (+<0.01%) |
:arrow_up: |
| devp2p | 82.12% <ø> (ø) |
|
| ethash | ∅ <ø> (∅) |
|
| evm | 73.91% <44.44%> (-0.15%) |
:arrow_down: |
| genesis | 99.98% <ø> (ø) |
|
| rlp | ∅ <ø> (∅) |
|
| statemanager | 77.00% <ø> (ø) |
|
| trie | 89.63% <ø> (+0.35%) |
:arrow_up: |
| tx | ? |
|
| util | 89.19% <ø> (ø) |
|
| vm | 79.49% <36.00%> (-0.37%) |
:arrow_down: |
| wallet | 88.35% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, super interesting work! 🤩 To be honest, we cannot promise at the point that we will take this into the main code base, so you might need to live with the situation to reference this as a PR or your own fork.
We'll see. We do not have super transparent ruling what to take in and what not (also to be honest here), at the moment we mostly integrate EIPS already included in HFs and occassionally we do some exceptions for "promising EIPs" which "doesn't bloat the code base too much". 😝
Admittedly these are very blurry "criterias". We'll discuss internally how we want to proceed here, maybe also worth to document this in a more explicit way.
We might also want to think along stuff like...
- See if we can make our stack (even more) modular, to make these kind of integrations easier and/or
- Make it easier to fork and publish the whole stack
(both rather for the cases that we do not integrate)
Again, we'll see. Will report back here, happy to take opinions/suggestions on that in between! 🙂
super interesting work! 🤩 To be honest, we cannot promise at the point that we will take this into the main code base, so you might need to live with the situation to reference this as a PR or your own fork.
That is ok.
The goal if for project like Remix to be able to track progress, and use the wip branch for their own prototypes.
We are trying to evaluate impact of the EIP and get feedback from devs ...