ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Common: consistent `GasPrices` naming

Open acolytec3 opened this issue 2 years ago • 2 comments

As discovered in #3035, the casing of the GasPrices subkeys in common/src/eips.ts is not consistent. This should be fixed and then simplify the code in places like in the getBaseFee helper where we call toLowerCase to remove this additional check (which in theory should also provide a small performance gain).

acolytec3 avatar Sep 18 '23 20:09 acolytec3

Just to add that this is a breaking change since these names are part of the public Common API, so we can't do these updates right now.

holgerd77 avatar Sep 19 '23 10:09 holgerd77

Have given this a more neutral title (I somewhat do like the camel case naming, so I would like to at least give this one additional round of thought what we do here (all lowercase vs consistent camel case). No dramatically strong opinion though. 😋

Will also add to the new breaking release tracking issue I created #3216

holgerd77 avatar Jan 08 '24 09:01 holgerd77