ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Hive: add devp2p:eth:* debug logs

Open holgerd77 opened this issue 2 years ago • 1 comments

When analyzing debug logs for failing Hive ETH tests one realizes that it is not really possible to follow the interchangings of the clients since there is absolutely not debug output on the message exchange (apart from some somewhat implicit (so: log happening elsewhere) TxPool: received new tx hashes number=50 message.

We should change that and add some very condense one-line ETH message debug output for inbound and outbound messages. So something in the line of:

  • Received GET_BLOCK_BODIES request from peer id=3b6d5707 for number=100 blocks (very very first shot, please optimize)

If this (issue) raises questions both before or during implementation please drop them here!

holgerd77 avatar Aug 22 '23 17:08 holgerd77

Forget the above. After an exchange with @acolytec3 we came to the conclusion that adding this to the client is eventually/likely too verbose and we therefore would want to settle to just deactivate the devp2p:ETH debug logger from the devp2p package for Hive (so: for all kind of tests).

While this is very verbose in the client, for Hive with its very limited 2 peer or so and few messages exchanges this should likely be acceptable (and if not we can still easily turn off again).

So this would mean: add ENV DEBUG=ethjs,devp2p:eth:* (tested the logger command locally and can confirm that this works with the applied spelling) to the dockerfile.

Can someone with the respective knowledge to do this in 5 minutes give this a quick shot? 😆

holgerd77 avatar Aug 22 '23 17:08 holgerd77