ethereumjs-monorepo
ethereumjs-monorepo copied to clipboard
ethereumjs
RPC method eth_feeHistory implementation
Implements: eth_feeHistory method for tracking historical gas information
Method is used as described in: https://docs.infura.io/networks/ethereum/json-rpc-methods/eth_feehistory
Hi @GitMark0, hope we didn't push you away here, but remarks like the one from @jochem-brouwer are simply part of our normal review process we also apply internally? 😬 🙂
Would it be possible to get this over the finish line? This would be somewhat of a pity otherwise, there is already so much great and extensive work in the PR here!
Hi @GitMark0, hope we didn't push you away here, but remarks like the one from @jochem-brouwer are simply part of our normal review process we also apply internally? 😬 🙂
Would it be possible to get this over the finish line? This would be somewhat of a pity otherwise, there is already so much great and extensive work in the PR here!
Hey @holgerd77 thanks for reaching out! Unfortunately I just didn't find time to finish the PR. I got really busy with a new (unplanned) project a day or two after I opened it... I'd love to finish the PR and continue contributing to the EthereumJS community and I hope that I'll have time to do it by the end of the month. Cheers!
@GitMark0 Hi Berry, I would assume you are fully caught in with your new duties, right? 🙂 Thanks for starting this great PR! We (respectively @jochem-brouwer from our team) would take this over now, we would cherry-pick your commits into a new PR (so that you retain ownership) and will the give this some finalization.
For now I would assume this is ok for you, let us know if you have reservations or some plain rejection here though!
All the best Holger
