ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

WIP - Rework CI for build jobs

Open acolytec3 opened this issue 2 years ago • 4 comments

This PR attempts to rework our entire CI workflow so that all of the jobs that build the monorepo are consolidated into a single workflow where step 1 is a build that installs all dependencies, builds all of the packages and then caches them. Then, each of the individual package workflows just restore that build image and run that package's tests and related workflows on it. I also added one global lint job to run all of the lint jobs at once in its own step.

acolytec3 avatar May 17 '23 13:05 acolytec3

Codecov Report

Merging #2709 (78b5e49) into master (515a7ba) will increase coverage by 2.40%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain ?
client ?
common 97.05% <ø> (ø)
devp2p ?
ethash ?
evm ?
rlp ?
statemanager ?
trie 89.92% <ø> (ø)
tx ?
util ?
vm 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 22 '23 13:05 codecov[bot]

Just revisting this here, cannot completely remember, what was the status of this?

Did I kill this off preliminary by being too sceptical about it? 😬 Or have there been some technical problems?

Now when revisiting I find this actually pretty solid and not really sure anymore where my biggest doubts were. 😬 😬 😬 (sorry for that eventually)

holgerd77 avatar Feb 20 '24 10:02 holgerd77

Just revisting this here, cannot completely remember, what was the status of this?

Did I kill this off preliminary by being too sceptical about it? 😬 Or have there been some technical problems?

Now when revisiting I find this actually pretty solid and not really sure anymore where my biggest doubts were. 😬 😬 😬 (sorry for that eventually)

I can certainly update it and see if it still works. I don't remember your specific concerns but I think it just got forgotten about.

acolytec3 avatar Feb 20 '24 11:02 acolytec3

I can certainly update it and see if it still works. I don't remember your specific concerns but I think it just got forgotten about.

👍🙂🙏

holgerd77 avatar Feb 26 '24 11:02 holgerd77