ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

EVM (potentially other): add commit versions to experimental EIP implementation references

Open holgerd77 opened this issue 2 years ago • 2 comments
trafficstars

A bit tedious to catch up but it would be good if we add EIP commit versions to our experimental (mostly) EVM (maybe other packages as well) EIP implementations. EIPs - especially if still in DRAFT state - often change frequently, and we had this case repeatedly that we couldn't really reference ourself what EIP state we had actually implemented and if we are "up to date", also for documentation purposes it would be good if we clearly communicate to people who want to test/use what EIP version is actually implemented and so what people can expect.

So task here would be to go through the list of EIPs (I guess more or less everything with experimental in it (e.g. transient storage, push0) except the EOF stuff which will likely be updated by @jochem-brouwer along his implementation) in evm.ts and in the corresponding README section and have a look at the commit history from an EIP page (e.g. EIP-2315 history) and find the commit where we have done the implementation (I guess easiest to find the EIP in the EVM CHANGELOG and then compare on the dates) and add something like:

  • EIP-1234 - Very big improvement (experimental, Version COMMIT HASH OR PR from 2022-05-04)

Something like that, first suggestion.

Side task would be to also have a bit a closer look if an EIP implementation we have is eventually outdated and then eventually open an issue on that, would also be helpful to then also label the above EIP reference with OUTDATED or something:

  • EIP-1234 - Very big improvement (experimental, Version COMMIT HASH OR PR from 2022-05-04, OUTDATED)

Bonus addition: the PR which then substantially updates the EIP later on:

  • EIP-1234 - Very big improvement (experimental, Version COMMIT HASH OR PR from 2022-05-04, OUTDATED, see EIP PR #1234567)

holgerd77 avatar Jan 03 '23 09:01 holgerd77

@holgerd77 I will like to work on this issue, I am applying from onlydust

odeyemitobi avatar Jun 05 '25 22:06 odeyemitobi

We are in a process of reorganization atm and cannot review PRs, please put on hold.

holgerd77 avatar Jun 12 '25 14:06 holgerd77

Hi, are you still in the process of reorganizing ? If yes, i would love to pick up the issue

Beutife avatar Oct 01 '25 13:10 Beutife