ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon ethereumjs

removed GetNodeData & NodeData

Open rashidmya opened this issue 3 years ago • 4 comments

Implemented eth/67

Removed:

  • GetNodeData
  • NodeData

Issue: #2262

rashidmya avatar Aug 31 '22 04:08 rashidmya

is this what you mean? @jochem-brouwer

rashidmya avatar Aug 31 '22 05:08 rashidmya

Yup, if you also could include a test which shows these methods are not reachable if one is on eth/67 then we can start to review it :)

jochem-brouwer avatar Aug 31 '22 06:08 jochem-brouwer

Please let's not merge this in any more before the final major version monorepo releases early next week.

Will give this a "Blocked" label for now, can be removed once final releases have been published.

holgerd77 avatar Aug 31 '22 08:08 holgerd77

Codecov Report

Merging #2263 (94eccd0) into master (0ea9df3) will not change coverage. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
vm 77.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 31 '22 08:08 codecov[bot]

I will go ahead and rebase this, @holgerd77 I think we can remove the blocked label here? I would like to go ahead and implement eth/68 as well. (Need this for hive tests)

jochem-brouwer avatar Jun 26 '23 17:06 jochem-brouwer

Will approve once CI passes

acolytec3 avatar Jul 12 '23 10:07 acolytec3

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 EthereumJS Contributor:

GitPOAP: 2023 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

gitpoap-bot[bot] avatar Jul 12 '23 11:07 gitpoap-bot[bot]