ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Add `state` tests to EVM package

Open acolytec3 opened this issue 3 years ago • 2 comments
trafficstars

We just explore moving the State Tests from ethereum/tests from the vm to the evm package since notionally we don't need the vm package to run these tests. This would involve cloning the stateTestRunner from vm and then making whatever modifications are needed to allow it to run the state tests with evm.runCall instead of vm.runTx

acolytec3 avatar Aug 17 '22 16:08 acolytec3

This is a super great idea which I also somewhat had when working on implementing retesteth. I think this is what we would want in the end. Especially the state tests are indeed made for this. This would also greatly improve EVM coverage :+1:

jochem-brouwer avatar Aug 17 '22 17:08 jochem-brouwer

This is a super great idea which I also somewhat had when working on implementing retesteth. I think this is what we would want in the end. Especially the state tests are indeed made for this. This would also greatly improve EVM coverage 👍

Ah, this gives me some confirmation, thanks! 🙂

@acolytec3 also, yes, makes a lot of sense to just adopt the test runner to use EVM directly and not do this circumvents I suggested with going into the VM folder or the like.

holgerd77 avatar Aug 18 '22 07:08 holgerd77

Since this didn’t make it into production for close to a year, with one active try, I would also have a tendency to close.

Feel free to reopen if you think this should rather be discussed and eventually picked up again!

holgerd77 avatar Aug 01 '23 08:08 holgerd77