ethereumjs-monorepo
ethereumjs-monorepo copied to clipboard
ethereumjs
chore(blockchain): enable `strict-boolean-expressions` rule for `eslint`
Part of https://github.com/ethereumjs/ethereumjs-monorepo/issues/2137 and depends on https://github.com/ethereumjs/ethereumjs-monorepo/pull/2143 being merged
Codecov Report
Merging #2144 (8a77fa8) into master (a87f179) will decrease coverage by
0.09%. The diff coverage is100.00%.
| Flag | Coverage Δ | |
|---|---|---|
| block | 92.77% <100.00%> (ø) |
|
| blockchain | ? |
|
| client | 87.07% <ø> (ø) |
|
| common | 98.09% <ø> (ø) |
|
| devp2p | 92.14% <ø> (-0.17%) |
:arrow_down: |
| ethash | ∅ <ø> (∅) |
|
| evm | 79.08% <ø> (ø) |
|
| rlp | ∅ <ø> (∅) |
|
| statemanager | 88.16% <ø> (ø) |
|
| trie | 89.43% <ø> (ø) |
|
| tx | 97.98% <ø> (ø) |
|
| util | 92.33% <ø> (ø) |
|
| vm | 85.27% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@acolytec3 yeah I want them merged in a specific order as I created them on top of each other branches. That's why all but 1 are marked as draft.
@acolytec3 yeah I want them merged in a specific order as I created them on top of each other branches. That's why all but 1 are marked as draft.
Where is the non-DRAFT one? 🙂
Used to be https://github.com/ethereumjs/ethereumjs-monorepo/pull/2143 but since you want to tag the stable releases soon I would rather wait with those and move them to develop once that branch is updated. There just won't be enough time to test these PRs properly.
Used to be #2143 but since you want to tag the stable releases soon I would rather wait with those and move them to develop once that branch is updated. There just won't be enough time to test these PRs properly.
Ah, no, we won't use develop for quite some time any more. Our normal procedure is to just develop towards master, which always represents our latest state of the work. The develop branch was just an exception to prepare for the breaking releases (we should have named this develop-v6 or something) and won't be used any time soon (we'll forget about any breaking changes in the next 4+ months 😋).
Alright, then I would still wait until the stable releases are tagged so there's no rush and time to properly test things and not introducing any last minute issues, especially with those things that affect all packages to various degrees.
Closing this since it falls in the same category as Uint8Array in terms of breaking changes/impact.