ethereumjs-monorepo
ethereumjs-monorepo copied to clipboard
Client: Fix Client Hive Execution Tests
We are now running with the Client within the Hive Execution test suite, yay!!! 🎉
Test results are still improvable and we should slowly work down, at least the ones which make currently sense for us (if this is related to some unimplemented feature: we should independently decide on that and not do the feature "for the tests" 😋). Here is an extract of the latest results:

Actually, this is all super-interesting, here are some sync suite test results:

(totally wasn't aware of the cross-client aspect of this)
The EthereumJS client definition in hive is missing some features, which makes a lot of tests fail.
Most failures I have seen are 'genesis hash mismatch' errors. These are a result of missing functionality in the genesis.json parser. You can run ./hive --sim smoke/genesis --client ethereumjs --docker.pull to see some of these errors in isolation.
EthereumJS is also missing a feature to import blocks on startup. In hive tests, the client can be initialized with a chain.rlp file containing blocks to be imported. The test can also request the client to import blocks from a directory of rlp files. See this document for more information: https://github.com/ethereum/hive/blob/master/docs/clients.md#files.
Thanks @fjl , will also link an issue and a PR;
https://github.com/ethereumjs/ethereumjs-monorepo/issues/2498
https://github.com/ethereumjs/ethereumjs-monorepo/pull/2507
We've made sufficient progress working on hive tests that it feels like this can safely be closed.