ethashjs icon indicating copy to clipboard operation
ethashjs copied to clipboard

Published 20 hours ago • verified publisher icon ethereumjs

Monorepo integration?

Open holgerd77 opened this issue 5 years ago • 5 comments

After having slept a night on this I think it would actually a lot of sense to add this to the monorepo.

@evertonfraga What do you think? Would this be a substantial additional integration effort or is this relatively easily doable now?

Follow-up on #20

holgerd77 avatar May 27 '20 10:05 holgerd77

That can be done rather easily now. Will work on it :)

evertonfraga avatar Jun 01 '20 19:06 evertonfraga

Thanks, currently trying to ping @wanderer for publishing rights.

holgerd77 avatar Jun 03 '20 09:06 holgerd77

(still one of the old libraries where these never have been transferred)

holgerd77 avatar Jun 03 '20 09:06 holgerd77

if we're planning to migrate it to the monorepo, it can be renamed to the scoped way: ethashjs => @ethereumjs/ethash.

evertonfraga avatar Jun 03 '20 10:06 evertonfraga

@evertonfraga yeah, sure, you're right, that will also be a way, forgot about that. Would nevertheless be nice to at least deprecate on the outdated npm package site at https://www.npmjs.com/package/ethashjs.

holgerd77 avatar Jun 03 '20 12:06 holgerd77