solidity
solidity copied to clipboard
Inventory of removed error codes to prevent reuse
Closes #13545
- added
REMOVED_IDSset in theerror_codes.py - found all previosly removed error codes and added to this set (with references to the files and removal commits)
- These error codes were already reused {'5883', '2314', '9239', '9609', '2450', '6546', '4316', '5798', '3881', '2657'}
- CI job
chk_errorcodeswas modified, added check that all removed errors in the current PR were added to theREMOVED_IDS- unfortunatelly circleci doesn't provide target branch for PR, so I hardcoded develop
- example of the failed ci job
- example of the successful job
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.
If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.
If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.
Not sure why ci/circleci: b_osx is failing, my changes shoudn't affect it
Yeah it's unrelated! We have issues with osx builds and our pedantic compiler settings. For some reason, boost will generate warnings despite being system library on macos with cmake 4.0.0. We switched the settings to less pedantic ones for a particular appleclang version but since that got bumped by CI, you're seeing these failures.