solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Fix array assignment and deletion at storage slot overflow boundary

Open r0qs opened this issue 8 months ago • 4 comments

Fixes https://github.com/ethereum/solidity/issues/15587

r0qs avatar Apr 07 '25 09:04 r0qs

Please include a link to the issue you're fixing in the PR description.

cameel avatar Apr 22 '25 22:04 cameel

If @ekpyron did, I'd probably be fine with it, but if I have to make the call myself, I'll need more time with the PR.

Take your time to make sure this is sound - it's rather delicate and we should make sure that we don't introduce new (and if we're unlucky even more likely) issues here in the attempt to fix an old corner-case.

ekpyron avatar May 07 '25 11:05 ekpyron

The uniswap external test is being killed due to out of memory: https://app.circleci.com/pipelines/github/argotorg/solidity/41038/workflows/820a5a2b-c58c-4edc-bec5-262d3258900f/jobs/1912320/resources

r0qs avatar Dec 09 '25 21:12 r0qs

The uniswap external test is being killed due to out of memory: https://app.circleci.com/pipelines/github/argotorg/solidity/41038/workflows/820a5a2b-c58c-4edc-bec5-262d3258900f/jobs/1912320/resources

Rebasing fixed the issue, since the resource_class was bumped in https://github.com/argotorg/solidity/pull/16317

r0qs avatar Dec 09 '25 21:12 r0qs