solidity
solidity copied to clipboard
chore: improve code readability and style in regressions.py and splitSources.py
- Updated docstrings and comments for clarity and grammatical correctness.
- Fixed phrasing: "sources into their own files" → "sources into separate files".
- Improved uncaught exception handling print formatting in
splitSources.py. - Replaced manual string slicing with
startswith()for better readability and Python best practices. - Standardized class naming:
regressor→Regressor. - Improved comment wording for non-ASCII handling.
- Minor whitespace and indentation adjustments.
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.
If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.
If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.
Hi @solidity – just a friendly reminder about PR #15959 (“chore: improve code readability and style in regressions.py and splitSources.py”). It updates docstrings, switches string slicing to startswith(), standardizes the Regressor class name, and refines exception handling in splitSources.py. When you get a moment, could you take a look? Thanks! 🚀
Thank you, @clonker, for catching and fixing that typo! Everything looks good to me now.
Could you please squash into one or two commits and rebase? We don't want to have merge commits on develop.
Hi @clonker,
I’ve squashed all changes into a single commit and rebased onto develop as requested.
Let me know if there’s anything else to adjust—thanks!